Allow spreading records in type constructors for const values #5061
+2,198
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abs0luty
force-pushed
the
spreading-in-const-records
branch
3 times, most recently
from
b2242d8 to
200b09a
Compare
abs0luty
changed the title
abs0luty
changed the title
abs0luty
force-pushed
the
spreading-in-const-records
branch
4 times, most recently
from
50c471a to
df799f4
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
df799f4 to
5d39a71
Compare
lpil
reviewed
Nov 10, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you! This will be a relly nice addition. I've left a few questions in line.
Could you add a test that ensures that pub const dog = Animal(..alice) emits the "fieldless record update" warning please 🙏
abs0luty
force-pushed
the
spreading-in-const-records
branch
3 times, most recently
from
84302ed to
5f48b6d
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
2 times, most recently
from
7f5b0cd to
3ca3271
Compare
lpil
reviewed
Nov 29, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you! Looking fab. I've left some notes inline, mostly around behaviour that doesn't match record updates for expressions.
abs0luty
force-pushed
the
spreading-in-const-records
branch
2 times, most recently
from
f8e45cb to
faaa1e5
Compare
lpil
reviewed
Dec 1, 2025
...c/type_/tests/snapshots/gleam_core__type___tests__errors__expression_constructor_update.snap
Outdated
Show resolved
Hide resolved
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
faaa1e5 to
c6bb035
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
4 times, most recently
from
9326063 to
e6a00d9
Compare
Contributor
Author
|
I suppose I now need to accommodate for changes in c2fed7e! |
abs0luty
force-pushed
the
spreading-in-const-records
branch
8 times, most recently
from
ed56e68 to
4f7ba1a
Compare
lpil
reviewed
Dec 5, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Can you make the error messages for constants exactly the same as expressions please 🙏
Could we not return the same error value for constants as expressions? Then they would be rendered the same to the user.
Contributor
Author
|
@lpil Absolutely, I can work on this! |
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
1dd8f75 to
57778f2
Compare
abs0luty
force-pushed
the
spreading-in-const-records
branch
3 times, most recently
from
a0f539f to
3ceec04
Compare
Contributor
Author
|
@lpil Dependency validation fails and this is not directly related to the PR 🤔
|
```gleam const a = Foo(1, 2) const b = Foo(..a, 3) ``` Code like this now compiles, which makes constant construction a lot simpler!
Accommodate for recent changes to error handling in const inference in c2fed7e
Remove unused insta snapshots including ones left after renaming const record update tests.
Refactor the record update logic so const updates use the same error types as regular record updates. This produces consistent messages for users and removes cases where similar problems surfaced in different forms. The change: - restores InvalidRecordConstructor instead of InvalidRecordUpdate with reasons - uses UnsafeRecordUpdate for variant mismatches to align with expression handling - adds a constructor_location field so the compiler can point at the constructor when reporting InvalidRecordConstructor - and introduces validation for incompatible field types in spreads
abs0luty
force-pushed
the
spreading-in-const-records
branch
from
3ceec04 to
5a89ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.