gleam update should return error if package does not exists #5171
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Dec 1, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Mm yes it's tricky, this bit of the codebase isn't very testable. What you've suggested sounds good to me.
compiler-core/src/error.rs
Outdated
| RemovedPackagesNotExist { packages: Vec<String> }, | ||
|
|
||
| #[error("Packages to update not exist: {}", packages.iter().join(", "))] | ||
| PackagesToUpdateNotExist { packages: Vec<String> }, |
| fn ensure_packages_exist_locally( | ||
| &self, | ||
| manifest: &Manifest, | ||
| packages: Vec<EcoString>, |
Member
There was a problem hiding this comment.
Take this by reference please 🙏
Suggested change
| packages: Vec<EcoString>, | |
| packages: &[EcoString], |
| } | ||
|
|
||
| fn ensure_packages_exist_locally( | ||
| &self, |
Member
There was a problem hiding this comment.
Doesn't look like self is used, so this should be a module function rather than a method on this struct.
vshakitskiy
force-pushed
the
update-error-if-not-exists
branch
3 times, most recently
from
150a5ab to
017d5e2
Compare
vshakitskiy
force-pushed
the
update-error-if-not-exists
branch
from
5f977fa to
c09dd5e
Compare
vshakitskiy
force-pushed
the
update-error-if-not-exists
branch
from
c09dd5e to
5ecddc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4836.
Continuation of #4887.
The only question is that I don't know how to test ensure_packages_exist_locally. Should I extract it to a standalone function outside of the impl block?