Fix: quoted replies incorrectly render user input as part of the quote#34216
Merged
wxiaoguang merged 2 commits intogo-gitea:mainfrom Apr 16, 2025
Merged
Fix: quoted replies incorrectly render user input as part of the quote#34216wxiaoguang merged 2 commits intogo-gitea:mainfrom
wxiaoguang merged 2 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Apr 16, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 16, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2025
* giteaofficial/main: Fix various misalignments and overflows (go-gitea#34227) Update net package (go-gitea#34228) Fix button alignments and remove unnecessary styles (go-gitea#34206) Fix project board links to related Pull Requests (go-gitea#34213) Fix empty repo clone panel border (go-gitea#34219) Fix: quoted replies incorrectly render user input as part of the quote (go-gitea#34216)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When clicking the "Quote reply" button, only a single line break (
\n) was added after the quoted content.As a result, the user's reply appeared to be part of the quote block when rendered in Markdown.
Solution
Updated the quote insertion logic so that it adds one more line break (
\n) work like GithubThis way, the cursor lands on a new line and the user's reply is no longer interpreted as part of the quote.
Before
After
References
Fixes #34177