Missing return JXL_FAILURE

apenchev · eustas · commit 57786fc4c31b · 2026-03-10T15:42:00.000+01:00
diff --git a/lib/extras/packed_image_convert.cc b/lib/extras/packed_image_convert.cc
@@ -338,7 +338,7 @@ Status ConvertFromExternalNoSizeCheck(const uint8_t* data, size_t xsize,
     JXL_RETURN_IF_ERROR(bits_per_sample > 8 && bits_per_sample <= 16);
   } else if (format.data_type != JXL_TYPE_FLOAT16 &&
              format.data_type != JXL_TYPE_FLOAT) {
-    JXL_FAILURE("unsupported pixel format data type %d", format.data_type);
+    return JXL_FAILURE("unsupported pixel format data type %d", format.data_type);
   }
 
   JXL_ENSURE(channel->xsize() == xsize);

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ Status ConvertFromExternalNoSizeCheck(const uint8_t* data, size_t xsize,`
`338`	`338`	`JXL_RETURN_IF_ERROR(bits_per_sample > 8 && bits_per_sample <= 16);`
`339`	`339`	`} else if (format.data_type != JXL_TYPE_FLOAT16 &&`
`340`	`340`	`format.data_type != JXL_TYPE_FLOAT) {`
`341`		`- JXL_FAILURE("unsupported pixel format data type %d", format.data_type);`
	`341`	`+ return JXL_FAILURE("unsupported pixel format data type %d", format.data_type);`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`JXL_ENSURE(channel->xsize() == xsize);`