Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

There is an unsuitable proto file for the Go language #109

@dictav

Description

@dictav

I apologize for writing this googleapis issue here, as googleapis has not enabled Issues.

I found a proto file that is not suitable for the Go language.
https://github.com/googleapis/googleapis/blob/master/google/ads/googleads/v10/resources/experiment_arm.proto

This file will be converted experiment_arm.pb.go by protoc-gen-go. However, the Go language compiler interprets the _arm suffix as an architecture type, so it cannot be compiled on non-ARM machines.
Of course, if you rename the file, there is no problem. I guess it's up to the person building the file to be careful, but it's a little uncool. Perhaps, it doesn't work well with automatic build system.

I think it would be better to avoid such file names.
What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p3Desirable enhancement or fix. May not be included in next release.type: questionRequest for information or clarification. Not an issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions