Skip to content

fix(log): preserve dict of rest async response headers #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ohmayr merged 2 commits into from
Dec 10, 2024
Merged

fix(log): preserve dict of rest async response headers #2288

ohmayr merged 2 commits into from
Dec 10, 2024

Conversation

@vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Dec 10, 2024

No description provided.

@vchudnov-g vchudnov-g requested a review from a team as a code owner December 10, 2024 19:47
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 10, 2024
@vchudnov-g
Copy link
Contributor Author

vchudnov-g commented Dec 10, 2024

I'm getting a bazel/bazelisk error locally so I can't regenerate the goldens. @ohmayr , maybe you could?

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 10, 2024
@vchudnov-g
Copy link
Contributor Author

vchudnov-g commented Dec 10, 2024

OK, I was able to update the goldens!

@ohmayr ohmayr merged commit b10cc21 into main Dec 10, 2024
126 checks passed
@ohmayr ohmayr deleted the log-fix-dict-json branch December 10, 2024 20:37
@release-please release-please bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ohmayr ohmayr ohmayr approved these changes

Assignees

@ohmayr ohmayr

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vchudnov-g @ohmayr