Conversation
src/index.ts
Outdated
| * | ||
| * @experimental | ||
| */ | ||
| export type AuthClients = InstanceType< |
There was a problem hiding this comment.
Not too sure about the name; AuthClients could imply AuthClient[]. Would something like AnyAuthClient be clearer?
There was a problem hiding this comment.
I see what you mean about the naming. AnyAuthClient works for me, or UnionAuthClients? this is a tough naming situation.
My other feedback is that there is a lot going on in the InstanceType and the Extract - is it possible to split this up into a couple of lines and to comment what's going on so it's easier to read? It's hard to parse just by looking at it
There was a problem hiding this comment.
Thanks, updated
src/index.ts
Outdated
| * | ||
| * @experimental | ||
| */ | ||
| export type AuthClients = InstanceType< |
There was a problem hiding this comment.
I see what you mean about the naming. AnyAuthClient works for me, or UnionAuthClients? this is a tough naming situation.
My other feedback is that there is a lot going on in the InstanceType and the Extract - is it possible to split this up into a couple of lines and to comment what's going on so it's easier to read? It's hard to parse just by looking at it
danielbankhead
changed the title
AuthClients typeAnyAuthClient type
3 participants
🦕