Skip to content

Conversation

@ShreyasSinha
Copy link
Contributor

Adding model classes for CompleteMultipartUpload request and response.
Implementing complete for Multipart Upload.
Refer: #3348

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Oct 30, 2025
@ShreyasSinha ShreyasSinha marked this pull request as ready for review October 30, 2025 13:39
@ShreyasSinha ShreyasSinha requested a review from a team as a code owner October 30, 2025 13:39
@ShreyasSinha ShreyasSinha added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2025
@BenWhitehead BenWhitehead mentioned this pull request Oct 30, 2025
10 tasks
@BenWhitehead
Copy link
Collaborator

You've got a compiler error, which is failing all your builds:

Error:  /home/runner/work/java-storage/java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java:[134,6] cannot find symbol
  symbol:   class Nullable
  location: class com.google.cloud.storage.MultipartUploadHttpRequestManager

@BenWhitehead BenWhitehead changed the title feat: Adding API for complete multipart upload. feat: add preview MultipartUploadClient#completeMultiparUpload Nov 3, 2025
@BenWhitehead BenWhitehead changed the title feat: add preview MultipartUploadClient#completeMultiparUpload feat: add preview MultipartUploadClient#completeMultipartUpload Nov 3, 2025
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <[email protected]>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <[email protected]>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
BEGIN_NESTED_COMMIT

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

END_NESTED_COMMIT

Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry

Co-authored-by: BenWhitehead <[email protected]>
@BenWhitehead
Copy link
Collaborator

merged to main in #3378

@BenWhitehead BenWhitehead deleted the mpu-feature-7 branch November 3, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants