fix: AccessEntry API representation parsing#1682
Merged
Linchin merged 4 commits intogoogleapis:mainfrom Oct 19, 2023
Merged
Conversation
Overriding the `AccessEntry#_properties` with a deep copy of the API resource overwrites the `role` property set in `AccessEntry.__init__` which isn't present in the resource if the `role` is set to `None`. This causes `AccessEntry`s generated from API representations to no longer evaluate to equal with equivalent `AccessEntry` resources instantiated through `AccessEntry.__init__`. The added unit test fails without the change and passes with the change.
product-auto-label
bot
added
size: s
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
requested review from
Linchin and
chalmerlowe
and removed request for
PhongChuong
Contributor
|
Hi @jonathan-ostrander, thank you so much for your contribution! The PR looks good, but it seems the lint test failed. As seen in the kokoro results: Please see the instructions in the contribution doc for more info on coding style. If you need any help, please let us know! :) |
Linchin
requested changes
Oct 18, 2023
Contributor
Linchin
left a comment
Linchin
left a comment
There was a problem hiding this comment.
please fix linting error
Contributor
Author
dandhlee
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Linchin
approved these changes
Oct 19, 2023
This was referenced Nov 7, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overriding the
AccessEntry#_propertieswith a deep copy of the API resource overwrites theroleproperty set inAccessEntry.__init__which isn't present in the resource if theroleis set toNone. This causesAccessEntrys generated from API representations to no longer evaluate to equal with equivalentAccessEntryresources instantiated throughAccessEntry.__init__. The added unit test fails without the change and passes with the change.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1681 🦕