feat: allow extra_api_info to be passed to api request #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
approved these changes
Apr 1, 2022
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
LGTM! Please update the docstring before merging.
added 2 commits
April 1, 2022 11:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to track retry metrics, we need to add extra information to the X-Goog-API-Client header.
https://docs.google.com/document/d/1xo1OlU2ESmVYUgpfn5FjCpRoH-f6JXxlRTQg_2FEdTQ/edit?resourcekey=0-hwjKNEbdT01zQ7QsZG3Srw
This is in line with how it is done in other parts of cloud such as cloud sdk.
This PR adds an extra argument to Connection.api_request and _make_request that allows for this extra_api_info to be passed in.