Skip to content

Commit ef48f0d

Browse files
matthew29tangcopybara-github
authored andcommitted
fix: Default to list base models (instead of tuned models)
PiperOrigin-RevId: 722817748
1 parent 219c13f commit ef48f0d

3 files changed

Lines changed: 14 additions & 14 deletions

File tree

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,12 @@ print(response.text)
122122
To retrieve tuned models, see [list tuned models](#list-tuned-models).
123123

124124
```python
125-
for model in client.models.list(config={'query_base':True}):
125+
for model in client.models.list():
126126
print(model)
127127
```
128128

129129
```python
130-
pager = client.models.list(config={"page_size": 10, 'query_base':True})
130+
pager = client.models.list(config={"page_size": 10})
131131
print(pager.page_size)
132132
print(pager[0])
133133
pager.next_page()
@@ -137,12 +137,12 @@ print(pager[0])
137137
#### Async
138138

139139
```python
140-
async for job in await client.aio.models.list(config={'query_base':True}):
140+
async for job in await client.aio.models.list():
141141
print(job)
142142
```
143143

144144
```python
145-
async_pager = await client.aio.models.list(config={"page_size": 10, 'query_base':True})
145+
async_pager = await client.aio.models.list(config={"page_size": 10})
146146
print(async_pager.page_size)
147147
print(async_pager[0])
148148
await async_pager.next_page()
@@ -801,12 +801,12 @@ print(tuned_model)
801801
To retrieve base models, see [list base models](#list-base-models).
802802

803803
```python
804-
for model in client.models.list(config={"page_size": 10}):
804+
for model in client.models.list(config={"page_size": 10, "query_base": False}):
805805
print(model)
806806
```
807807

808808
```python
809-
pager = client.models.list(config={"page_size": 10})
809+
pager = client.models.list(config={"page_size": 10, "query_base": False})
810810
print(pager.page_size)
811811
print(pager[0])
812812
pager.next_page()
@@ -816,12 +816,12 @@ print(pager[0])
816816
#### Async
817817

818818
```python
819-
async for job in await client.aio.models.list(config={"page_size": 10}):
819+
async for job in await client.aio.models.list(config={"page_size": 10, "query_base": False}):
820820
print(job)
821821
```
822822

823823
```python
824-
async_pager = await client.aio.models.list(config={"page_size": 10})
824+
async_pager = await client.aio.models.list(config={"page_size": 10, "query_base": False})
825825
print(async_pager.page_size)
826826
print(async_pager[0])
827827
await async_pager.next_page()

google/genai/models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4780,8 +4780,8 @@ def list(
47804780
) -> Pager[types.Model]:
47814781
"""Makes an API request to list the available models.
47824782
4783-
If `query_base` is set to True in the config, the API will return all
4784-
available base models. If set to False or not set (default), it will return
4783+
If `query_base` is set to True in the config or not set (default), the
4784+
API will return all available base models. If set to False, it will return
47854785
all tuned models.
47864786
47874787
Args:
@@ -4804,6 +4804,8 @@ def list(
48044804
types._ListModelsParameters(config=config).config
48054805
or types.ListModelsConfig()
48064806
)
4807+
if config.query_base is None:
4808+
config.query_base = True
48074809
if self._api_client.vertexai:
48084810
config = config.copy()
48094811
if not config.query_base:
@@ -4814,8 +4816,6 @@ def list(
48144816
if filter_value
48154817
else 'labels.tune-type:*'
48164818
)
4817-
if not config.query_base:
4818-
config.query_base = False
48194819
return Pager(
48204820
'models',
48214821
self._list,

google/genai/tests/models/test_list.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
test_table: list[pytest_helper.TestTableItem] = [
3030
pytest_helper.TestTableItem(
3131
name='test_tuned_models',
32-
parameters=types._ListModelsParameters(),
32+
parameters=types._ListModelsParameters(config={'query_base': False}),
3333
),
3434
pytest_helper.TestTableItem(
3535
name='test_base_models',
36-
parameters=types._ListModelsParameters(config={'query_base': True}),
36+
parameters=types._ListModelsParameters(),
3737
),
3838
pytest_helper.TestTableItem(
3939
name='test_base_models_with_config',

0 commit comments

Comments
 (0)