From a3bd58bda6be61edac51642105436839cf037539 Mon Sep 17 00:00:00 2001 From: snipe Date: Thu, 16 Oct 2025 11:17:48 +0100 Subject: [PATCH 1/6] Foundation --- resources/views/blade/form-label.blade.php | 4 ++ resources/views/blade/form-row.blade.php | 65 ++++++++++++++++++++ resources/views/blade/form-tooltip.blade.php | 4 ++ resources/views/blade/input/text.blade.php | 12 ++++ resources/views/categories/edit.blade.php | 8 ++- 5 files changed, 92 insertions(+), 1 deletion(-) create mode 100644 resources/views/blade/form-label.blade.php create mode 100644 resources/views/blade/form-row.blade.php create mode 100644 resources/views/blade/form-tooltip.blade.php create mode 100644 resources/views/blade/input/text.blade.php diff --git a/resources/views/blade/form-label.blade.php b/resources/views/blade/form-label.blade.php new file mode 100644 index 000000000000..cf0599fca85c --- /dev/null +++ b/resources/views/blade/form-label.blade.php @@ -0,0 +1,4 @@ + + \ No newline at end of file diff --git a/resources/views/blade/form-row.blade.php b/resources/views/blade/form-row.blade.php new file mode 100644 index 000000000000..b7d33d728105 --- /dev/null +++ b/resources/views/blade/form-row.blade.php @@ -0,0 +1,65 @@ + +@props([ + 'name' => null, + 'type' => 'text', + 'item' => null, + 'info_tooltip_text' => null, + 'help_text' => null, + 'label' => null, +]) + +
merge(['class' => 'form-group']) }}> + + @if (isset($label)) + + {{ $label }} + + @endif + + @php + $blade_type = in_array($type, ['text', 'email', 'url', 'tel', 'number', 'password']) ? 'text' : $type; + @endphp +
+ +
+ + @if ($info_tooltip_text) + +
+ + {{ $info_tooltip_text }} + +
+ @endif + + + @error($name) + +
merge(['class' => $error_offset_class]) }}> + + + {{ $message }} + +
+ @enderror + + @if ($help_text) + +
merge(['class' => $error_offset_class]) }}> +

+ {!! $help_text !!} +

+
+ @endif + +
\ No newline at end of file diff --git a/resources/views/blade/form-tooltip.blade.php b/resources/views/blade/form-tooltip.blade.php new file mode 100644 index 000000000000..c8a45dcc84f7 --- /dev/null +++ b/resources/views/blade/form-tooltip.blade.php @@ -0,0 +1,4 @@ + + + {{ $slot }} + \ No newline at end of file diff --git a/resources/views/blade/input/text.blade.php b/resources/views/blade/input/text.blade.php new file mode 100644 index 000000000000..188bd5cf3ad3 --- /dev/null +++ b/resources/views/blade/input/text.blade.php @@ -0,0 +1,12 @@ +@props([ +'input_style' => null, +'input_group_addon' => null, +'required' => false, +'item' => null, +]) + +merge(['class' => 'form-control']) }} + @required($required) +/> + diff --git a/resources/views/categories/edit.blade.php b/resources/views/categories/edit.blade.php index fd9efcc49f41..d3a88916139c 100755 --- a/resources/views/categories/edit.blade.php +++ b/resources/views/categories/edit.blade.php @@ -9,7 +9,13 @@ @section('inputFields') -@include ('partials.forms.edit.name', ['translated_name' => trans('admin/categories/general.name')]) + + +
From 90d040573dfcb0290e50a253e00d1b9e03fcb760 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 29 Oct 2025 16:07:16 +0000 Subject: [PATCH 2/6] Added regular link icon --- app/Helpers/IconHelper.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/Helpers/IconHelper.php b/app/Helpers/IconHelper.php index 8172f2bbbbde..bf505870ab83 100644 --- a/app/Helpers/IconHelper.php +++ b/app/Helpers/IconHelper.php @@ -40,6 +40,8 @@ public static function icon($type) { return 'fa-solid fa-trash-arrow-up'; case 'external-link': return 'fa fa-external-link'; + case 'link': + return 'fa fa-link'; case 'email': return 'fa-regular fa-envelope'; case 'phone': From 73159076f610acf8caf9a2d50654095594e4085e Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 29 Oct 2025 16:11:37 +0000 Subject: [PATCH 3/6] Better handle input groups in js validator --- resources/views/layouts/default.blade.php | 39 +++++++++++++++++------ 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/resources/views/layouts/default.blade.php b/resources/views/layouts/default.blade.php index e4f41281e114..ab9da217eb87 100644 --- a/resources/views/layouts/default.blade.php +++ b/resources/views/layouts/default.blade.php @@ -1163,21 +1163,42 @@ var validator = $('#create-form').validate({ ignore: 'input[type=hidden]', errorClass: 'alert-msg', - errorElement: 'span', + errorElement: 'div', errorPlacement: function(error, element) { - $(element).hasClass('select2') || $(element).hasClass('js-data-ajax') + + if ($(element).hasClass('select2') || $(element).hasClass('js-data-ajax')) { // If the element is a select2 then append the error to the parent div - ? element.parent('div').append(error) - // Otherwise place it after - : error.insertAfter(element); + element.parent('div').append(error); + + } else if ($(element).parent().hasClass('input-group')) { + var end_input_group = $(element).next('.input-group-addon').parent(); + error.insertAfter(end_input_group); + } else { + error.insertAfter(element); + } + }, highlight: function(inputElement) { - $(inputElement).parent().addClass('has-error'); - $(inputElement).closest('.help-block').remove(); + + // We have to go two levels up if it's an input group + if ($(inputElement).parent().hasClass('input-group')) { + $(inputElement).parent().parent().parent().addClass('has-error'); + } else { + $(inputElement).parent().addClass('has-error'); + $(inputElement).closest('.help-block').remove(); + } + }, onfocusout: function(element) { - $(element).parent().removeClass('has-error'); - return $(element).valid(); + // We have to go two levels up if it's an input group + if ($(element).parent().hasClass('input-group')) { + $(element).parent().parent().parent().removeClass('has-error'); + return $(element).valid(); + } else { + $(element).parent().removeClass('has-error'); + return $(element).valid(); + } + }, }); From e2c3480194f42b7c24213a45c028f6967cc19240 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 29 Oct 2025 16:11:47 +0000 Subject: [PATCH 4/6] Apply form rows to manufacturers --- resources/views/manufacturers/edit.blade.php | 126 ++++++++++--------- 1 file changed, 70 insertions(+), 56 deletions(-) diff --git a/resources/views/manufacturers/edit.blade.php b/resources/views/manufacturers/edit.blade.php index 1c9b80777608..6b9d5834fe82 100755 --- a/resources/views/manufacturers/edit.blade.php +++ b/resources/views/manufacturers/edit.blade.php @@ -9,75 +9,89 @@ {{-- Page content --}} @section('inputFields') -@include ('partials.forms.edit.name', ['translated_name' => trans('admin/manufacturers/table.name')]) + + + + -
- -
- - {!! $errors->first('url', '') !!} -
-
+ + + -
- -
- - {!! $errors->first('support_url', '') !!} -
-
+ + + -
- -
- -

{!! trans('admin/manufacturers/message.support_url_help') !!}

- {!! $errors->first('warranty_lookup_url', '') !!} -
-
+ -
- -
- - {!! $errors->first('support_phone', '') !!} -
-
+ + -
- -
- - {!! $errors->first('support_email', '') !!} -
-
+ + @include ('partials.forms.edit.image-upload', ['image_path' => app('manufacturers_upload_path')]) -
- -
- - {!! $errors->first('notes', '') !!} -
-
+ + @stop From 4bbf923eb6bc5fb85f333099af9e1de8dfe223e0 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 29 Oct 2025 16:11:56 +0000 Subject: [PATCH 5/6] Smaller default row for textarea --- resources/views/blade/input/textarea.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/blade/input/textarea.blade.php b/resources/views/blade/input/textarea.blade.php index f75d58f067df..784bf503130f 100644 --- a/resources/views/blade/input/textarea.blade.php +++ b/resources/views/blade/input/textarea.blade.php @@ -1,6 +1,6 @@ @props([ 'value' => '', - 'rows' => 10, + 'rows' => 5, ])