grpclog: skip unrecognized component log levels instead of defaulting to fatal

Author: 110y

grpclog/component.go

@@ -164,10 +164,6 @@ func Component(componentName string) DepthLoggerV2 {
 			c.errorDepth = func(depth int, args ...any) {
 				componentErrorDepth(depth+1, args...)
 			}
-		case severityFatal:
-			c.infoDepth = noopDepth
-			c.warningDepth = noopDepth
-			c.errorDepth = noopDepth
 		}
 	}
 

grpclog/component_test.go

@@ -69,13 +69,9 @@ func TestParseComponentLogLevel(t *testing.T) {
 			},
 		},
 		{
-			name:  "mixed-case level names are treated as unknown and default to FATAL",
+			name:  "mixed-case level names are treated as unknown and skipped",
 			input: "dns:Error,xds:Warning,authz:Info",
-			want: map[string]severityLevel{
-				"dns":   severityFatal,
-				"xds":   severityFatal,
-				"authz": severityFatal,
-			},
+			want:  map[string]severityLevel{},
 		},
 		{
 			name:  "parses multiple comma-separated components with different levels",
@@ -102,10 +98,9 @@ func TestParseComponentLogLevel(t *testing.T) {
 			},
 		},
 		{
-			name:  "unrecognized level name defaults to FATAL",
+			name:  "unrecognized level name is skipped",
 			input: "dns:UNKNOWN,xds:ERROR",
 			want: map[string]severityLevel{
-				"dns": severityFatal,
 				"xds": severityError,
 			},
 		},
@@ -220,11 +215,14 @@ func TestLogger(t *testing.T) {
 			},
 		},
 		{
-			name:              "FATAL GRPC_GO_COMPONENT_LOG_LEVEL suppresses all non-fatal logs",
+			name:              "unrecognized GRPC_GO_COMPONENT_LOG_LEVEL falls back to global default",
 			componentLogLevel: "dns:FATAL",
 			logSeverityLevel:  "INFO",
 			components:        []string{"dns", "balancer"},
 			want: []string{
+				"INFO: [dns] dns-info",
+				"WARNING: [dns] dns-warning",
+				"ERROR: [dns] dns-error",
 				"INFO: [balancer] balancer-info",
 				"WARNING: [balancer] balancer-warning",
 				"ERROR: [balancer] balancer-error",

grpclog/grpclog.go

@@ -58,7 +58,6 @@ const (
 	severityInfo severityLevel = iota
 	severityWarning
 	severityError
-	severityFatal
 )
 
 func parseComponentLogLevels(logLevel string) map[string]severityLevel {
@@ -85,7 +84,7 @@ func parseComponentLogLevels(logLevel string) map[string]severityLevel {
 		case "ERROR", "error":
 			logLevels[component] = severityError
 		default:
-			logLevels[component] = severityFatal
+			continue
 		}
 	}
 	return logLevels