@@ -224,7 +224,7 @@ private boolean canSendRemoteNotification() {
224224 String remotePhoneNumber = preferences .getRemotePhoneNumber ();
225225 String signalUsername = preferences .getSignalUsername ();
226226 return !remotePhoneNumber .isEmpty () && !getCountryCode ().equalsIgnoreCase (remotePhoneNumber ) &&
227- !TextUtils .isEmpty (signalUsername );
227+ !TextUtils .isEmpty (signalUsername ) && ! getCountryCode (). equalsIgnoreCase ( signalUsername ) ;
228228 }
229229
230230 /**
@@ -245,6 +245,16 @@ private void collectDataForRemoteNotification() {
245245 }
246246 }
247247
248+ private void onRemoteNotificationParameterChange () {
249+ SwitchPreference switchPreference =
250+ (SwitchPreference ) findPreference (PreferenceManager .REMOTE_NOTIFICATION_ACTIVE );
251+
252+ boolean remoteNotificationActive = canSendRemoteNotification ();
253+ preferences .setRemoteNotificationActive (remoteNotificationActive );
254+
255+ switchPreference .setChecked (remoteNotificationActive );
256+ }
257+
248258 @ Override
249259 public boolean onOptionsItemSelected (MenuItem item ) {
250260 switch (item .getItemId ()) {
@@ -391,17 +401,17 @@ public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, Strin
391401 preferences .setSignalUsername ("" );
392402 findPreference (PreferenceManager .REGISTER_SIGNAL ).setSummary (R .string .register_signal_desc );
393403 }
404+ onRemoteNotificationParameterChange ();
394405 break ;
395406 case PreferenceManager .VERIFY_SIGNAL : {
396407 String text = ((EditTextPreference ) findPreference (PreferenceManager .VERIFY_SIGNAL )).getText ();
397408 activateSignal (preferences .getSignalUsername (), text );
409+ onRemoteNotificationParameterChange ();
398410 break ;
399411 }
400- case PreferenceManager .REMOTE_NOTIFICATION_ACTIVE :
401- // todo not - needed: Test this out.
402- break ;
403412 case PreferenceManager .REMOTE_PHONE_NUMBER :
404413 setPhoneNumber ();
414+ onRemoteNotificationParameterChange ();
405415 break ;
406416 case PreferenceManager .NOTIFICATION_TIME :
407417 try
0 commit comments