Conversation
nmccready
reviewed
Jun 18, 2017
|
|
||
| // The 2nd argument can be given as a path string | ||
| sourcemap.write(file, './maps', function(err, updatedFile, sourcemapFile) { | ||
| // sourcemapFile will be a Vinyl file to be written to some location |
There was a problem hiding this comment.
Looks good to me. However, you might want to move section 15-24 to after line 58. I recommend this as the below explanations are much more thorough. The below makes it clear that all the files are Vinyl file objects where only line 22 above makes that explicit.
Anyway, if you like it the way it is then merge away.
Member
Author
There was a problem hiding this comment.
Thanks for taking a look. Our standard gulp-org docs template has the simplified usage first followed by the detailed API docs, so I'll probably keep it in this order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@contra @stevelacy Can you guys review this? Maybe @robinvenneman @nmccready if you have bandwidth.