Fix some potential bugs and some semantics

Signed-off-by: Nova <[email protected]>

Author: aelithron

src/main/java/com/hackclub/hccore/listeners/ServerListPingListener.java

@@ -12,6 +12,8 @@ public ServerListPingListener(HCCorePlugin plugin) {
   }
   @EventHandler
   public void serverListPing(PaperServerListPingEvent e) {
-    e.setServerIcon(plugin.serverIcon);
+    if (plugin.serverIcon != null) {
+      e.setServerIcon(plugin.serverIcon);
+    }
   }
 }

src/main/java/com/hackclub/hccore/tasks/IconTask.java

@@ -17,15 +17,16 @@
 
 public class IconTask implements Runnable {
   private final HCCorePlugin plugin;
+  private final HttpClient client;
   public IconTask(HCCorePlugin plugin) {
     this.plugin = plugin;
+    this.client = HttpClient.newHttpClient();
   }
 
   @Override
   public void run() {
     Logger logger = plugin.getLogger();
 
-    HttpClient client = HttpClient.newHttpClient();
     // get the icon url from Shrimp Shuffler
     HttpRequest ssRequest = HttpRequest.newBuilder()
         .uri(URI.create("https://shrimp-shuffler.a.hackclub.dev/api/current"))
@@ -74,20 +75,20 @@ public void run() {
       ByteArrayInputStream in = new ByteArrayInputStream(cdnResponse.body());
       image = ImageIO.read(in);
     } catch (IOException e) {
-      logger.severe("Failed to load the current icon from the file!");
+      logger.severe("Failed to load the current icon from the CDN response!");
       logger.severe(e.getMessage());
       return;
     }
     if (image == null) {
-      logger.severe("Failed to load the current icon from the file!");
+      logger.severe("Failed to load the current icon from the CDN response!");
       return;
     }
     BufferedImage serverIcon = resizeToIcon(image);
     Bukkit.getScheduler().runTask(plugin, () -> {
       try {
         plugin.serverIcon = Bukkit.loadServerIcon(serverIcon);
       } catch (Exception e) {
-        logger.severe("Failed to load the current icon from the file!");
+        logger.severe("Failed to cache the current icon!");
         logger.severe(e.getMessage());
       }
     });

src/main/resources/config.yml

@@ -3,7 +3,7 @@ claim-stickers-url: "https://example.com/claim-stickers"
 settings:
   # Time in seconds after which a player will be automatically set to AFK
   auto-afk-time: 600
-  # Time in seconds that a request is made to the Shrimp Shuffler API to change the server icon.
+  # Time in seconds between requests are made to the Shrimp Shuffler API to change the server icon.
   icon-change-time: 600
   spawn-command:
     # Radius extending from the world spawn in which the command can be used