Skip to content

Add Czech language#9343

Merged
budnix merged 4 commits into
handsontable:developfrom
Ashus:master
Mar 24, 2022
Merged

Add Czech language#9343
budnix merged 4 commits into
handsontable:developfrom
Ashus:master

Conversation

@Ashus
Copy link
Copy Markdown
Contributor

@Ashus Ashus commented Mar 22, 2022

Context

This adds support for Czech language to Handsontable

How has this been tested?

It builds locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

None.

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@AMBudnik
Copy link
Copy Markdown
Contributor

Hi @Ashus

Thank you very much for filling our language base with the Czech language. Could you please alter the branch to developer? Contributing guide states that

Always target your PR at the develop branch, not the master branch.

@Ashus Ashus changed the base branch from master to develop March 23, 2022 09:02
@Ashus
Copy link
Copy Markdown
Contributor Author

Ashus commented Mar 23, 2022

Sorry about that, it is changed now.

@AMBudnik
Copy link
Copy Markdown
Contributor

Great! Thank you very much. I will ask the dev team to review your PR.

@budnix
Copy link
Copy Markdown
Member

budnix commented Mar 23, 2022

@Ashus Can I ask you to add a changelog entry to this PR? Basically, to do that you need to execute the npm run changelog entry command in the root directory, follow the instructions and commit the generated file. Here you can find an explanation of how it works.

@Ashus
Copy link
Copy Markdown
Contributor Author

Ashus commented Mar 24, 2022

Changelog entry added. I had to use cygwin console though.

@budnix budnix merged commit b6e77df into handsontable:develop Mar 24, 2022
@budnix
Copy link
Copy Markdown
Member

budnix commented Mar 24, 2022

@kirszenbaum Can I ask you to add the Czech language to the documentation?

@kirszenbaum
Copy link
Copy Markdown
Contributor

@kirszenbaum Can I ask you to add the Czech language to the documentation?

@budnix - done: #9353

@warpech
Copy link
Copy Markdown
Member

warpech commented Mar 30, 2022

@Ashus, do you have an opinion about the country name that we should put in the docs? #9354 (comment)

@Ashus
Copy link
Copy Markdown
Contributor Author

Ashus commented Mar 30, 2022

@warpech, after discussing Wikipedia, I think Czechia is better as it is geographical and not political name.

@AMBudnik
Copy link
Copy Markdown
Contributor

Hi @Ashus

Thank you again for your input. We just released Handsontable v12.1.0 where your translation is available.

@adrianszymanski89
Copy link
Copy Markdown
Contributor

Hi @Ashus. We just announced an introduction of a new functionality called Copy with headers. Could you help us to translate three short lines for the context menu?

Here you can find more information about it: #10112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants