fix: btrfs volumes can not be formatted (#421)#424
Merged
Conversation
|
Thanks for this. I think it would be great if you could also add examples on how to use it and what options can be specified with mountOpts/mountOptions - like compression. It's one of the undersupported use cases (having compression file system) in kubernetes, and i believe everyone would greatly benefit. I found this issue while tinkering with the csi driver and trying to do exactly that and seeing it wasn't supported yet :) |
Member
|
It looks like the Kubernetes CSI tests do not have a test pattern for btrfs, so it does not actually get tested with the enabled. I tested it locally and it successfully created, formatted and mounted the volume :) |
apricote
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.