Skip to content

Fixed SI units for current consumption (smappee component)#13190

Merged
fabaff merged 1 commit intohome-assistant:devfrom
vandenberghev:dev
Mar 14, 2018
Merged

Fixed SI units for current consumption (smappee component)#13190
fabaff merged 1 commit intohome-assistant:devfrom
vandenberghev:dev

Conversation

@vandenberghev
Copy link
Copy Markdown
Contributor

Total consumption should be in kWh. not kW.

@homeassistant homeassistant added platform: sensor.smappee small-pr PRs with less than 30 lines. labels Mar 13, 2018
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @vandenberghev,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Mar 14, 2018

Breaking change:
The unit of measurement of the consumptions were changed to kWh.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 948f295 into home-assistant:dev Mar 14, 2018
engrbm87 pushed a commit to engrbm87/home-assistant-core that referenced this pull request Mar 20, 2018
@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants