feat: end support Node.js v18 (#317)

Author: yusukebe

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 22.x, 24.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4

README.md

@@ -38,13 +38,7 @@ Statistics        Avg      Stdev        Max
 
 ## Requirements
 
-It works on Node.js versions greater than 18.x. The specific required Node.js versions are as follows:
-
-- 18.x => 18.14.1+
-- 19.x => 19.7.0+
-- 20.x => 20.0.0+
-
-Essentially, you can simply use the latest version of each major release.
+It works on Node.js versions greater than 20.x.
 
 ## Installation
 

package.json

@@ -77,7 +77,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=18.14.1"
+    "node": ">=20"
   },
   "devDependencies": {
     "@hono/eslint-config": "^1.0.1",

src/globals.ts

@@ -20,7 +20,6 @@ import {
   buildOutgoingHttpHeaders,
 } from './utils'
 import { X_ALREADY_SENT } from './utils/response/constants'
-import './globals'
 
 const outgoingEnded = Symbol('outgoingEnded')
 type OutgoingHasOutgoingEnded = Http2ServerResponse & {

src/listener.ts

@@ -35,8 +35,8 @@ export class Request extends GlobalRequest {
     }
     // Check if body is ReadableStream like. This makes it compatbile with ReadableStream polyfills.
     if (typeof (options?.body as ReadableStream)?.getReader !== 'undefined') {
-      // node 18 fetch needs half duplex mode when request body is stream
-      // if already set, do nothing since a Request object was passed to the options or explicitly set by the user.
+      // Half duplex mode is required when request body is a stream.
+      // If already set, do nothing since a Request object was passed to the options or explicitly set by the user.
       ;(options as any).duplex ??= 'half'
     }
     super(input, options)