fix: install docker-compose when compose-version is specified#234
Merged
neilime merged 1 commit intohoverkraft-tech:mainfrom Feb 3, 2026
Merged
fix: install docker-compose when compose-version is specified#234neilime merged 1 commit intohoverkraft-tech:mainfrom
neilime merged 1 commit intohoverkraft-tech:mainfrom
Conversation
5 tasks
Member
|
@jmpargana can you run Thanks |
8fe363d to
0480739
Compare
Contributor
Author
@neilime thanks for looking into it. I had failed to rebase with Is there something I can do locally? |
Member
|
Thanks @jmpargana for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes issue #232, where the action fails on self-hosted runners that have Docker installed but do not have Docker Compose, even when compose-version is explicitly provided.
Root cause
The logic responsible for setting up Docker Compose did not properly handle the case where:
Instead of installing Docker Compose, the action proceeded without error handling before checking or installing.
Changes introduced
Related issue
Closes #232