Skip to content

fix: install docker-compose when compose-version is specified#234

Merged
neilime merged 1 commit intohoverkraft-tech:mainfrom
jmpargana:main
Feb 3, 2026
Merged

fix: install docker-compose when compose-version is specified#234
neilime merged 1 commit intohoverkraft-tech:mainfrom
jmpargana:main

Conversation

@jmpargana
Copy link
Contributor

Context

This PR fixes issue #232, where the action fails on self-hosted runners that have Docker installed but do not have Docker Compose, even when compose-version is explicitly provided.

Root cause

The logic responsible for setting up Docker Compose did not properly handle the case where:

  • Docker Compose is not installed, and
  • compose-version is specified.

Instead of installing Docker Compose, the action proceeded without error handling before checking or installing.

Changes introduced

  • Ensure Docker Compose is installed when compose-version is provided, regardless of runner type (hosted or self-hosted).

Related issue

Closes #232

@jmpargana jmpargana changed the title Fix Docker Compose installation on self-hosted runners when compose-version is specified fix: install docker-compose on self-hosted runners when compose-version is specified Feb 3, 2026
@jmpargana jmpargana changed the title fix: install docker-compose on self-hosted runners when compose-version is specified fix: install docker-compose when compose-version is specified Feb 3, 2026
@neilime
Copy link
Member

neilime commented Feb 3, 2026

@jmpargana can you run make ci to ensure the code is ready for CI

Thanks

@jmpargana jmpargana force-pushed the main branch 2 times, most recently from 8fe363d to 0480739 Compare February 3, 2026 09:09
@jmpargana
Copy link
Contributor Author

@jmpargana can you run make ci to ensure the code is ready for CI

Thanks

@neilime thanks for looking into it. I had failed to rebase with main also. Now it has the generated index.js and make ci passes locally. The only thing failing in the CI is a missing permission for the OIDC token.

Is there something I can do locally?

@neilime neilime merged commit c36b7c1 into hoverkraft-tech:main Feb 3, 2026
16 of 19 checks passed
@neilime
Copy link
Member

neilime commented Feb 3, 2026

Thanks @jmpargana for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker Compose not installed on self-hosted runners even when compose-version is specified

2 participants