Skip to content

Conversation

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Sep 15, 2024

@sum2012 sum2012 added the I/O Affected by I/O timing settings, or other kind of I/O issue. label Sep 15, 2024
@anr2me
Copy link
Collaborator

anr2me commented Sep 15, 2024

i see that JPCSP also use the same value, nice find!
So 0-2 are reserved for STDIN, STDOUT, STDERR, similar to most commercial Unix systems where /dev/stdin is symlinked to /dev/fd/0 or /proc/self/fd/0

@hrydgard
Copy link
Owner

Hm, seems right, nice one - though, I'm wondering if we should add savestate versioning for this - let old states keep the old minimum, and old stdin number. However, given how ID allocation currently works, and that no games actually use stdin as far as I know, I think the risk for problems is probably really small...

I'll have another look at the code soon and probably merge this today.

@hrydgard hrydgard added this to the v1.18.0 milestone Sep 15, 2024
@hrydgard
Copy link
Owner

Yeah I can't figure out how this change could possibly break existing savestates, anything, unless a game was silly enough to use > or < on file handles and made assumptions on the results. So let's just go with it as it is, it's clearly right.

@hrydgard hrydgard enabled auto-merge September 15, 2024 22:08
@hrydgard hrydgard merged commit 5e635aa into hrydgard:master Sep 15, 2024
@sum2012 sum2012 deleted the io--minor branch September 22, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I/O Affected by I/O timing settings, or other kind of I/O issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distorted garbage textures in "Lick It" demo

3 participants