Sysex MIDI messages in PortMidi #1773
Description
Operating system + version : Windows
Audio driver + version : PortMidi
Determining the actual type of an incoming MIDI message in CoreMidiDriver::midiProc and PortMidiDriver::PortMidiDriver_thread are both done by the first byte of the incoming message. The only difference is that CoreMidiDriver assigns type MidiMessage::SYSEX for a certain range of values and PortMidiDriver assigns type MidiMessage::SYSTEM_EXCLUSIVE.
But the result is totally different since MidiMessage::SYSEX is used for incoming MMC_x events in the MidiMap while MidiMessage::SYSTEM_EXCLUSIVE are explicitly discarded.
SYSEX and SYSTEM_EXCLUSIVE are treated as synonyms in all references I came across during a short search.
It feels a lot like this was done on accident but, unfortunately, it is there since the beginning of our git history.