feat(transport): added support for EC keys#1145
Merged
LucioFranco merged 2 commits intohyperium:masterfrom Feb 13, 2023
Merged
Conversation
Fixes: hyperium#1143 Signed-off-by: Yu Juncen <yu745514916@live.com>
LucioFranco
reviewed
Nov 9, 2022
tonic/src/transport/service/tls.rs
Outdated
| use crate::transport::Identity; | ||
|
|
||
| fn load_rustls_private_key( | ||
| pub(crate) fn load_rustls_private_key( |
Member
There was a problem hiding this comment.
Why pub(crate), I don't see this used outside of the crate or am I going crazy?
Contributor
Author
There was a problem hiding this comment.
I want to use it in the tests module, if I remove this rustc would blame me load_rustls_private_key is a private function... Are there some better solutions?
Well, I guess pub(super) is what we need?
Signed-off-by: Yu Juncen <yu745514916@live.com>
LucioFranco
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yu Juncen yu745514916@live.com
Motivation
This PR tries to fix #1143. Which caused tonic reports error when using
ECkeys as client keys.Solution
The solution has been described in the issue. Copy & paste it here: