Add optional service methods#275
Merged
LucioFranco merged 6 commits intohyperium:masterfrom Jul 10, 2020
Merged
Conversation
LucioFranco
reviewed
Feb 28, 2020
271ed17 to
ce7c725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#265
Solution
This is currently an incomplete solution - it is the minimum required to demonstrate this approach and allow for a decision.
It mirrors closely the way
optional_layermethod works.Considerations
NamedServicebe implemented onEitherlike this? Does this break anything?Unimplementedservice which seems to do the same thing asEmptyService, perhaps we should use that instead?TODO
After deciding whether this approach is feasible the following needs to be done:
add_optional_serviceonto theRouterin a similar manner