fix(block_sync): check that next block has height +1 #5111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shanin Roman <[email protected]>
Erigara
requested review from
0x009922,
DCNick3,
SamHSmith,
dima74,
mversic,
outoftardis and
s8sato
as code owners
0x009922
approved these changes
Sep 30, 2024
mversic
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #5072.
After more than 2 blocks was shared through block stream this problem appeared.
Solution
Bug was that code checked that
blocks[i].height -1 == blocks[i + 1].height, when should beblcoks[i].height + 1 == blocks[i + 1].height.Tests were added to check this validation.