refactor: replace sort.Slice with slices.Sort for natural ordering (#5376)

Signed-off-by: slightsharp <slightsharp@outlook.com>

Author: slightsharp

internal/peer/chaincode/common_test.go

@@ -14,7 +14,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
-	"sort"
+	"slices"
 	"testing"
 	"time"
 
@@ -808,7 +808,7 @@ func TestProcessProposals(t *testing.T) {
 		for _, response := range responses {
 			statuses = append(statuses, response.Response.Status)
 		}
-		sort.Slice(statuses, func(i, j int) bool { return statuses[i] < statuses[j] })
+		slices.Sort(statuses)
 		require.EqualValues(t, []int32{200, 300, 400, 500}, statuses)
 	})
 	t.Run("should return an error from processing a proposal for a single peer", func(t *testing.T) {

orderer/consensus/smartbft/util.go

@@ -13,7 +13,7 @@ import (
 	"encoding/hex"
 	"encoding/pem"
 	"fmt"
-	"sort"
+	"slices"
 	"time"
 
 	"github.com/hyperledger-labs/SmartBFT/pkg/types"
@@ -367,9 +367,7 @@ func remoteNodesFromConfigBlock(block *cb.Block, logger *flogging.FabricLogger,
 		})
 	}
 
-	sort.Slice(nodeIDs, func(i, j int) bool {
-		return nodeIDs[i] < nodeIDs[j]
-	})
+	slices.Sort(nodeIDs)
 
 	return &nodeConfig{
 		consenters:    oc.Consenters(),

orderer/consensus/smartbft/util_network_test.go

@@ -12,7 +12,6 @@ import (
 	"path/filepath"
 	"reflect"
 	"slices"
-	"sort"
 	"sync"
 	"sync/atomic"
 	"testing"
@@ -562,9 +561,7 @@ func createBFTChainUsingMocks(t *testing.T, node *Node, configInfo *ConfigInfo)
 				nodeIds = append(nodeIds, nodeId)
 			}
 
-			sort.Slice(nodeIds, func(i, j int) bool {
-				return nodeIds[i] < nodeIds[j]
-			})
+			slices.Sort(nodeIds)
 
 			return nodeIds
 		}).Maybe()