Hy2Foam Porting

[gutiel2]

Hey I had some questions as I am currently porting Hy2Foam over. I was able to compile it with a recent version of OpenFOAM, but was wondering what phaseName entailed as well as the purpose for dictionaryConstructorTable versus fvMeshConstructorTable. Currently, I am thinking about moving everything over to a dictionaryConstructor, but was wondering if there was any logic or other pitfalls I should be wary before I begin this endeavor. Any help is greatly appreciated! Thank you!

[Toddilson12]

Hi. I also ported the code for hy2Foam (all libs and execs). I compiled with version v2412. So far, it has given the same results as v1706. I am not very experienced with OpenFOAM code or hyStrath, so take everything I write with a grain of salt.

About the phaseName, I guess it belongs to the original thermo classes, but is unused in hyStrath. As far as I know, it is meant to be used in multiphase flows.

As for the dictionary constructors, I imagine you are talking about cstrIter and the ::iterators. This change is necessary due to the different dictionary macros defined in the classes. They changed throughout the versions. In most cases, you can compare the original hyStrath classes/methods with the original counterparts in the version you are porting to. For example, basic2ThermoTemplates.C can be compared with basicThermoTemplates.C. In the newer code, the auto keyword has been used more frequently. Sometimes, cstrIter is being changed to an auto pointer (often named ctorPtr), but a quick fix is to just replace the whole ::iterator type with auto and keep the rest the same.

I am not sure if there are any pitfalls or issues that may arise from doing these substitutions, but it has worked for me. You can check my modifications on croquemadame's fork.

I hope this helps you!

[gutiel2]

Thank you so much for responding! Thank you so much for the explanation. After I get my hy2Foam running (I too am new and need the practice porting) I will definitely investigate and see how we differ.