Add support for Namada by yito88 · Pull Request #3705 · informalsystems/hermes

yito88 · 2023-11-21T13:08:38Z

Closes: #XXX

Description

To transfer tokens between Namada and Cosmos-base chains.

Add Namada to ChainConfig
Reuse CosmosSdkConfig for generating Tendermint light clients
Add NamadaChain as ChainEndpoint implementation
- See crates/relayer/src/chain/namada.rs and files under crates/relayer/src/chain/namada
- To submit Namada transactions and query
Store Namada key to KeyRing

PR author checklist:

Added changelog entry, using unclog.
Added tests: integration (for Hermes) or unit/mock tests (for modules).
Linked to GitHub issue.
Updated code comments and documentation (e.g., docs/).
Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

Reviewed Files changed in the GitHub PR explorer.
Manually tested (in case integration/unit/mock tests are absent).

….1-namada Update yuji 1.7.1 namada

ljoss17

Added some nits.
In addition:

For the MSRV, it needs to be updated to v1.79.0 due to parity-scale-codec@3.7.0 requires rustc 1.79.0
For cargo doc, we can use the stable toolchain instead of nightly-2024-04-21

tools/test-framework/src/bootstrap/namada.rs

tools/test-framework/src/chain/cli/query.rs

tools/test-framework/src/chain/config/namada.rs

tools/test-framework/src/relayer/transfer.rs

crates/relayer-cli/src/commands/keys/add.rs

ljoss17 · 2024-11-26T15:28:36Z

Sorry it seems that for cargo doc we need the nightly build, toolchain: nightly-2024-10-15 should work.
For the Rust MSRV we can update cargo msrv to v0.17.1 and remove the -- 'cargo check --all-features' from the CLI call

romac · 2024-12-02T10:06:42Z

.github/workflows/namada.yaml

+  workflow_dispatch:
+  pull_request:
+    paths:
+      - .github/workflows/integration.yaml


Suggested change

- .github/workflows/integration.yaml

- .github/workflows/namada.yaml

romac · 2024-12-02T10:07:32Z

.github/workflows/namada.yaml

+      fail-fast: false
+      matrix:
+        chain:
+          - package: .#gaia18


@ljoss17 Let's add Osmosis there as well?

Yes, we could also update to Gaia 20. I will look into this

romac · 2024-12-02T10:08:53Z

.github/workflows/namada.yaml

+        env:
+          OPERATING_SYSTEM: Linux
+        run: |
+          release_url=$(curl -s "https://api.github.com/repos/anoma/namada/releases/188247367" | grep "browser_download_url" | cut -d '"' -f 4 | grep "$OPERATING_SYSTEM")


@yito88 Is there a way to automatically pull the latest deployed version of Namada, to ensure we stay up to date consistently without having to change the workflow file everytime?

There is no way for now I think. We need to update the URL when a new version is released.

romac · 2024-12-02T10:10:44Z

ci/release/hermes.Dockerfile

@@ -6,9 +6,23 @@
 FROM rust:1-buster AS build-env


@ljoss17 Let's trigger this workflow manually from the branch before merging to make sure it works

Done https://github.com/informalsystems/hermes/actions/runs/12124241201

romac · 2024-12-02T10:13:52Z

crates/relayer/src/chain/client.rs

        // TODO: extract Tendermint-related configs into a separate substructure
        // that can be used both by CosmosSdkConfig and configs for nonSDK chains.


@ljoss17 Let's open an issue for this, would make the code much nicer eventually

.changelog/unreleased/features/3705-support-namada.md

Co-authored-by: Romain Ruetschi <github@romac.me> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com>

romac · 2024-12-03T10:25:19Z

Amazing work @yito88, thank you so much for all this stellar work you have done! 🚀🙏🥇💙

And thanks so much @ljoss17 as well for shepherding this PR for the past year! 🙌🙏💙

This reverts commit 00a0cf5.

Add support for relaying between Namada and Cosmos-base chains. - Add Namada to `ChainConfig` - Reuse `CosmosSdkConfig` for generating Tendermint light clients - Add `NamadaChain` as `ChainEndpoint` implementation - See `crates/relayer/src/chain/namada.rs` and files under `crates/relayer/src/chain/namada` - To submit Namada transactions and query - Store Namada key to KeyRing --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Gianmarco Fraccaroli <gianmarco.fraccaroli@gmail.com> Co-authored-by: Tomáš Zemanovič <tomas@heliax.dev> Co-authored-by: Romain Ruetschi <github@romac.me>

This reverts commit 00a0cf5.

* Update Cargo.lock * Revert "Add support for Namada (#3705)" This reverts commit 00a0cf5. * Cargo clippy fix * Formatting --------- Co-authored-by: Luca Joss <luca@informal.systems>

Add support for relaying between Namada and Cosmos-base chains. - Add Namada to `ChainConfig` - Reuse `CosmosSdkConfig` for generating Tendermint light clients - Add `NamadaChain` as `ChainEndpoint` implementation - See `crates/relayer/src/chain/namada.rs` and files under `crates/relayer/src/chain/namada` - To submit Namada transactions and query - Store Namada key to KeyRing --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Gianmarco Fraccaroli <gianmarco.fraccaroli@gmail.com> Co-authored-by: Tomáš Zemanovič <tomas@heliax.dev> Co-authored-by: Romain Ruetschi <github@romac.me>

* Update CHANGELOG.md * Create unclog release * Bump versions * Update Cargo.lock * Revert "Add support for Namada (#3705)" This reverts commit 00a0cf5. * Cargo clippy fix * Add support for Namada (#3705) Add support for relaying between Namada and Cosmos-base chains. - Add Namada to `ChainConfig` - Reuse `CosmosSdkConfig` for generating Tendermint light clients - Add `NamadaChain` as `ChainEndpoint` implementation - See `crates/relayer/src/chain/namada.rs` and files under `crates/relayer/src/chain/namada` - To submit Namada transactions and query - Store Namada key to KeyRing --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Gianmarco Fraccaroli <gianmarco.fraccaroli@gmail.com> Co-authored-by: Tomáš Zemanovič <tomas@heliax.dev> Co-authored-by: Romain Ruetschi <github@romac.me> * Update release to v1.10.5 * Add support for Namada (#3705) Add support for relaying between Namada and Cosmos-base chains. - Add Namada to `ChainConfig` - Reuse `CosmosSdkConfig` for generating Tendermint light clients - Add `NamadaChain` as `ChainEndpoint` implementation - See `crates/relayer/src/chain/namada.rs` and files under `crates/relayer/src/chain/namada` - To submit Namada transactions and query - Store Namada key to KeyRing --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Co-authored-by: Gianmarco Fraccaroli <gianmarco.fraccaroli@gmail.com> Co-authored-by: Tomáš Zemanovič <tomas@heliax.dev> Co-authored-by: Romain Ruetschi <github@romac.me> * Spellcheck * fix clippy * Update nix flake * Fix query balance command to be compatible with Osmosis v27 * Fix command output parsing for Osmosis * Set explicit timeout to 4 hours for Namada to Namada CI job * Add memory swap and reduce CPU overload for Namada<->Namada CI job * Add jlumbroso/free-disk-space@main step for Namada CI job * to Namada v1.1.0 (#4293) * for namada-net/namada#3797 * fix unbonding period * use pos_params.withdrawable_epoch_offset * just unbonding_len * Namada v1.1.0 * update Namada url for CI * ubuntu 24 for Namada binaries * fix for trusting period * Use Namada SDK release from crates.io * Update nix flake * Update CI with Namada v1.1.1 (#4295) * update CI for Namada v1.1.1 * update error message --------- Signed-off-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Yuji Ito <yito88@users.noreply.github.com> Co-authored-by: Gianmarco Fraccaroli <gianmarco.fraccaroli@gmail.com> Co-authored-by: Tomáš Zemanovič <tomas@heliax.dev> Co-authored-by: Romain Ruetschi <github@romac.me>

yito88 added 21 commits November 21, 2023 11:14

add NamadaChain

e35931e

fix wallet and PosParams

8153fb6

add test scripts

83211e7

fix compat_mode

ba2c88a

fix scripts for Namada v0.25.0

2ea4cdb

add relaying tests

a0f26d1

fix config type and scripts

0a4bc26

minor fix for scripts

d0e75e8

install protoc for CI

c17e112

fix tests

b6cc2fa

fix tests

3cf5d17

fix sim test

f01effc

fix test-framework doc

d7b6c7a

change Namada key handling

446787f

fix scripts for adding namada keys

7fa06a2

support encrypted key

bb519c4

workaround for serde_json deserialization of ChainConfig

6a96579

fix after merge upstream

d87f272

clean up Namada error

5e279ce

use only namada_sdk

2d6272b

Namada 0.27.0

c939c7b

yito88 marked this pull request as ready for review November 21, 2023 16:05

yito88 added 3 commits November 23, 2023 15:53

check Namada WriteAck event in NewBlock

764973d

Namada 0.28.0

8cd572d

Namada 0.29.0

e22c2d5

romac changed the title ~~Add Namada ChainEndpoint~~ Add support for Namada Jan 18, 2024

ljoss17 and others added 4 commits February 21, 2024 14:40

Merge branch 'master' into yuji/1.7.1-namada

a8d6b9b

Fix issues post-merge

d0522c6

Merge pull request #25 from informalsystems/luca_joss/update-yuji-1.7…

7a1f964

….1-namada Update yuji 1.7.1 namada

Namada 0.30.0

4eee0e6

yito88 added 3 commits November 21, 2024 21:23

avoid updating Namada's tendermint-rs

9af782d

Merge branch 'master'

5436a2f

Namada v0.46.0 and remove test scripts

9161baf

ljoss17 reviewed Nov 26, 2024

View reviewed changes

fix according to feedback

b8b85b5

yito88 added 10 commits November 26, 2024 16:57

fix for msrv and cargo-doc

3a42a9b

fix for msrv

03a9657

add protoc installation for msrv

d5043c0

msrv logs

8a1ce8f

fix dockerfile

44dcf32

Namada v0.46.1

1f3bf44

for clippy of rust 1.83.0

57f0d4f

for clippy of rust 1.83.0

a96100f

for clippy of rust 1.83.0

a719662

for clippy of rust 1.83.0

31049b1

romac reviewed Dec 2, 2024

View reviewed changes

yito88 added 3 commits December 2, 2024 13:18

add changelog

df7d47b

update to gaia20, add tests between osmosis and namada

d349d5a

fix pr trigger path

58b4eaa

romac reviewed Dec 3, 2024

View reviewed changes

.changelog/unreleased/features/3705-support-namada.md Outdated Show resolved Hide resolved

Update .changelog/unreleased/features/3705-support-namada.md

2100927

Co-authored-by: Romain Ruetschi <github@romac.me> Signed-off-by: Yuji Ito <yito88@users.noreply.github.com>

romac merged commit 00a0cf5 into informalsystems:master Dec 3, 2024

ljoss17 added a commit that referenced this pull request Dec 13, 2024

Revert "Add support for Namada (#3705)"

bd57a08

This reverts commit 00a0cf5.

romac pushed a commit that referenced this pull request Dec 13, 2024

Revert "Add support for Namada (#3705)"

37bcece

This reverts commit 00a0cf5.

	- .github/workflows/integration.yaml
	- .github/workflows/namada.yaml

		// TODO: extract Tendermint-related configs into a separate substructure
		// that can be used both by CosmosSdkConfig and configs for nonSDK chains.

Comments

Conversation

yito88 commented Nov 21, 2023

Description

PR author checklist:

Reviewer checklist:

Uh oh!

ljoss17 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljoss17 commented Nov 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ljoss17 Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

romac commented Dec 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ljoss17 Dec 2, 2024 •

edited

Loading