Skip to content

fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing#1428

Merged
romac merged 2 commits intocometbft:mainfrom
ec2:ec2/nullable_validator_updates
May 29, 2024
Merged

fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing#1428
romac merged 2 commits intocometbft:mainfrom
ec2:ec2/nullable_validator_updates

Conversation

@ec2
Copy link
Contributor

@ec2 ec2 commented May 24, 2024

Fixes: #1427

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac
Copy link
Contributor

romac commented May 29, 2024

Thanks for the PR! Can you please a changelog entry in .changelog/unreleased/improvements/?

@romac romac changed the title FinalizeBlock's validator_updates should be nullable fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing May 29, 2024
@ec2
Copy link
Contributor Author

ec2 commented May 29, 2024

@romac I've added the changelog :)

Copy link
Contributor

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romac romac merged commit 9697006 into cometbft:main May 29, 2024
melekes added a commit to cometbft/cometbft-rs that referenced this pull request May 28, 2025
melekes added a commit to cometbft/cometbft-rs that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FinalizeBlock Response Deserialization Bug

2 participants