rpc: Add new dialect for v0.38 in order to fix changes in misbehaviour evidence serialization#1467
Merged
rpc: Add new dialect for v0.38 in order to fix changes in misbehaviour evidence serialization#1467
Conversation
7 tasks
romac
force-pushed
the
romac/v038-evidence
branch
2 times, most recently
from
df8901e to
f81ae58
Compare
romac
force-pushed
the
romac/v038-evidence
branch
from
f81ae58 to
ccc53d4
Compare
ljoss17
reviewed
Oct 23, 2024
rpc/src/endpoint/block.rs
Outdated
| pub data: Vec<Vec<u8>>, | ||
|
|
||
| /// Evidence of malfeasance | ||
| // #[serde(with = "self::evidence_serializers")] |
Contributor
Author
There was a problem hiding this comment.
Yes since it does not have any impact given that we deserialize through RawBlock
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 10, 2025
…r evidence serialization Port-of: cometbft/tendermint-rs#1467 Closes #99
melekes
added a commit
to cometbft/cometbft-rs
that referenced
this pull request
Jun 19, 2025
#100) …r evidence serialization Port-of: cometbft/tendermint-rs#1467 Closes #99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically for these changes (Issue, PR)
.changelog/