Skip to content

fix: strip auth info from url to avoid double authorization header#1494

Merged
romac merged 2 commits intocometbft:mainfrom
gjermundgaraba:gjermund/fix-double-auth-header
Apr 1, 2025
Merged

fix: strip auth info from url to avoid double authorization header#1494
romac merged 2 commits intocometbft:mainfrom
gjermundgaraba:gjermund/fix-double-auth-header

Conversation

@gjermundgaraba
Copy link
Contributor

@gjermundgaraba gjermundgaraba commented Mar 28, 2025

Closes: #1495

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Copy link
Contributor

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@romac romac merged commit 261f8a4 into cometbft:main Apr 1, 2025
21 of 22 checks passed
@gjermundgaraba gjermundgaraba deleted the gjermund/fix-double-auth-header branch April 1, 2025 22:34
melekes added a commit to cometbft/cometbft-rs that referenced this pull request Jun 10, 2025
melekes added a commit to cometbft/cometbft-rs that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tendermint-rpc creates double double authorizaion header

2 participants