Fix for #body_params causing undefined method `size'#210
Merged
dblock merged 2 commits intoruby-grape:masterfrom Jul 23, 2012
Merged
Fix for #body_params causing undefined method `size'#210dblock merged 2 commits intoruby-grape:masterfrom
dblock merged 2 commits intoruby-grape:masterfrom
Conversation
dblock
added a commit
that referenced
this pull request
Jul 23, 2012
Fix for #body_params causing undefined method `size'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An addition in #205 which adds a
request.body.sizecall started causing a 'NoMethodError' exception during "real" non test POST/PUT requests. This error could not be reproduced in a test environment because of the way rack/test wraps request information. During a real life request the request.body type is a Rack::Lint::InputWrapper object. But during a mock scenario a StringIO object. This subtle difference makes it difficult (if not impossible) to reproduce in a test environment without forcing the env to use the InputWrapper object. Changingrequest.body.sizetorequest.content_lengtheliminates the exception and serves the same purpose.This pull request also cleans up a related duplicate test found in the endpoint spec.