Removed error_format, will match the request content-type matched format.#285
Merged
dblock merged 1 commit intoruby-grape:masterfrom Dec 3, 2012
Merged
Removed error_format, will match the request content-type matched format.#285dblock merged 1 commit intoruby-grape:masterfrom
dblock merged 1 commit intoruby-grape:masterfrom
Conversation
dblock
added a commit
that referenced
this pull request
Dec 3, 2012
Removed error_format, will match the request content-type matched format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the discussion in #282.
This removes
error_format. It's confusing to expect JSON as a response, but get an error in txt format. With this change that is no longer possible, and the error format is matched the same way as the response format.