Request body not included in params when issuing a PATCH request#335
Closed
FreakenK wants to merge 4 commits intoruby-grape:masterfrom
Closed
Request body not included in params when issuing a PATCH request#335FreakenK wants to merge 4 commits intoruby-grape:masterfrom
FreakenK wants to merge 4 commits intoruby-grape:masterfrom
Conversation
Member
|
Thanks. I'd like to merge this. It needs a test and a line in CHANGELOG, please. |
Author
|
After digging a little deeper and after reading a couple of old related issues, we found the "real" place where the fix should be put. |
Author
|
Here you go. I also added a test case for a PUT request since there was none (only 1 test for POST with a misleading comment stating that the test was for POST/PUT). |
Member
|
Committed in f72135b with some changes to specs, thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The params hash does not contain parameters contained in the request body when issuing a PATCH request. Commit fixes this issue.