Skip to content

fixed assignment default_error_formatter#477

Closed
vad4msiu wants to merge 1 commit intoruby-grape:masterfrom
vad4msiu:fix_default_error_formatter
Closed

fixed assignment default_error_formatter#477
vad4msiu wants to merge 1 commit intoruby-grape:masterfrom
vad4msiu:fix_default_error_formatter

Conversation

@vad4msiu
Copy link
Copy Markdown
Contributor

I created json api with settings:

class Application < Grape::API
  ...
  content_type :json, "application/json"
  default_error_formatter :json
  error_formatter :json, ::Userbase::Errors::JsonFormatter
  ...
end

When I make request '/something' without '.json' I get rescue

NoMethodError:
 undefined method `call' for :json:Symbol
# ./lib/grape/middleware/error.rb:75:in `format_message'
# ./lib/grape/middleware/error.rb:63:in `error_response'
# ./lib/grape/middleware/error.rb:27:in `call!'
# ./lib/grape/middleware/base.rb:18:in `call'
# ./lib/grape/endpoint.rb:155:in `call!'
# ./lib/grape/endpoint.rb:145:in `call'
# ./lib/grape/api.rb:493:in `call'
# ./lib/grape/api.rb:42:in `call!'
# ./lib/grape/api.rb:38:in `call'

Because in method default_error_formatter assigned name formatter instead of being looking for via formatter_for.

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 26, 2013

Thanks, it's clearly a bug, merging. Do update CHANGELOG next time, please.

@dblock
Copy link
Copy Markdown
Member

dblock commented Sep 26, 2013

Merged via 6e418d3, thank you.

@dblock dblock closed this Sep 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants