use default_error_status if set in error! function#520
Closed
salimane wants to merge 2 commits intoruby-grape:masterfrom
Closed
use default_error_status if set in error! function#520salimane wants to merge 2 commits intoruby-grape:masterfrom
salimane wants to merge 2 commits intoruby-grape:masterfrom
Conversation
Member
|
This needs tests, a changelog and a README entry. Also see https://travis-ci.org/intridea/grape/jobs/14813250. |
Contributor
Author
|
Added requested changes and Travis is now happy :) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
default_error_statusis set, the endpointerror!function still uses a hardcoded403http status code.This pr sets the http status code used in the
error!function to use thedefault_error_statuswhatever it is.Thanks