Skip to content

Set status for endpoints when an error occours#698

Merged
dblock merged 1 commit intoruby-grape:masterfrom
dspaeth-faber:set_endpoint_status_for_errors
Jul 30, 2014
Merged

Set status for endpoints when an error occours#698
dblock merged 1 commit intoruby-grape:masterfrom
dspaeth-faber:set_endpoint_status_for_errors

Conversation

@dspaeth-faber
Copy link
Copy Markdown
Contributor

With this PR status for EndPoint is set when an error accour's like mentioned in #697.
So a ErrorFormatter can use the status.

Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EndPoint is actually Endpoint, please fix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@dblock
Copy link
Copy Markdown
Member

dblock commented Jul 30, 2014

While we're at it. What's status before it's set? I think it should be 200 via whatever the default is, right? Maybe add a spec for that and document status in README?

@dblock
Copy link
Copy Markdown
Member

dblock commented Jul 30, 2014

Merging this, though, thx.

dblock added a commit that referenced this pull request Jul 30, 2014
…rors

Set status for endpoints when an error occours
@dblock dblock merged commit 52b63db into ruby-grape:master Jul 30, 2014
@dspaeth-faber dspaeth-faber deleted the set_endpoint_status_for_errors branch July 30, 2014 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants