chore: Add version constraints for bootstrap dependencies#996
Conversation
- melos@7.4.1
The `collection`, `meta`, and `path` dependencies under `melos.command.bootstrap.dependencies` were using `any`, which causes `dart pub publish --dry-run` to warn about missing version constraints.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's dependency management by replacing broad 'any' version specifications with explicit version constraints for key packages ( Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the collection, meta, and path dependencies in pubspec.yaml to their latest stable versions. A review comment highlights an inconsistency with the path dependency, noting that other parts of the file might reference an invalid version (^1.9.1). To ensure consistency and prevent potential build failures, all path dependency constraints should be aligned to ^1.9.0.
Summary
anywith explicit version constraints forcollection(^1.19.0),meta(^1.16.0), andpath(^1.9.0) undermelos.command.bootstrap.dependenciesin the rootpubspec.yamlpackages/melos/pubspec.yamlbut missed the bootstrap configTest plan
melos bsto verify bootstrap still resolves correctlymelos exec -- dart pub publish --dry-runto confirm the 3 warnings are gone