fix(icon): icon names with numbers are correctly converted to kebab case#1339
Merged
liamdebeasi merged 2 commits intoionic-team:mainfrom Mar 13, 2024
Merged
fix(icon): icon names with numbers are correctly converted to kebab case#1339liamdebeasi merged 2 commits intoionic-team:mainfrom
liamdebeasi merged 2 commits intoionic-team:mainfrom
Conversation
liamdebeasi
changed the title
liamdebeasi
approved these changes
Mar 13, 2024
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Apologies for the delay in reviewing this. Thanks for fixing this!
Contributor
|
Merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1338
Do not contribute very often publicly, so any feedback regarding the pull request is welcome.
I know I jumped the gun by providing a pull request before the bug report has been validated.
I extended the existing test to cover the case with numbers. I keept the old test in place to avoid regression.
Unfortunately I can not link this pull request to my bug report: #1338