fix: filled ellipsis circle icons renders correctly#1353
Merged
liamdebeasi merged 5 commits intomainfrom Mar 22, 2024
Merged
Conversation
liamdebeasi
changed the title
liamdebeasi
requested review from
a team and
thetaPC
and removed request for
a team
christian-bromann
pushed a commit
to christian-bromann/ionicons
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1320
main
The filled variants of the ellipsis circle icons still render as outlines. To fix this, I made the outline icon the same as the sharp icon. For this case it's fine to use the sharp icon SVG for filled because the icon is supposed to be circles. In other words, there are no rounded corners to make not rounded (unlike the chat bubble shown in these demos).