feat: migrate from cap 7 to cap 8 #28

ItsChaceD · 2025-11-10T16:27:58Z

Upgrade Capacitor core to next
Upgrade Gradle to 8.14.3
Upgrade AGP to 8.13.0
Upgrade Android minSDK to 24 and compileSDK to 36
Upgrade AndroidX lib versions
Replace deprecated propName value syntax with propName = value
Replace deprecated kotlinOptions syntax
Upgrade iOS deployment target to 15.0

src/index.ts

OS-pedrogustavobilro · 2025-11-12T11:02:48Z

src/index.ts

 }

+function updateDeprecatedPropertySyntax(gradleFile: string): string {
+  const propertiesToUpdate = [


This script ends up changing more property assignments that we actually changed for our plugins - i.e. the ones that had gradle warnings.

I don't think it's necessarily bad to change assignment for all these properties, or at least I didn't get any errors nor warnings myself, but if we want to keep changes to a minimum, we can restrict these to the fewer properties that gradle seems to complain about.

I did run into some issues where ./gradlew clean lint build test -b build.gradle --warning-mode all would not log all of the warnings.. But then when going to Android Studio there would be more props that would actually be highlighted. As a result, I just included any property where I thought it made sense to update the syntax, even if there wasn't an explicit warning, in case the linter was not accurate.

I think it's better to be proactive since the documentation is pretty vague on which properties are actually affected (https://docs.gradle.org/current/userguide/upgrading_version_8.html#groovy_space_assignment_syntax)

Thoughts?

Yeah fair enough, not foreseeing any side effects so everything should be good.

Resolving this comment.

If we do this then we should do it for our plugins too, and document it

Added it to the documentation. I will make the changes in the plugins as well for the variables that have not been updated to the recommended syntax yet

Since we ended up not updating the plugins since then, for now it will just be quicker to remove some gradle properties from this command and only include the ones we updated for plugins.

fyi @OS-ruimoreiramendes

package.json

src/index.ts

OS-ruimoreiramendes · 2025-11-28T15:33:38Z

@jcesarmobile I’ve applied the changes you requested on updateKotlinOptions to remove the extra whitespace and update the JVM version.

jcesarmobile · 2025-12-01T14:48:23Z

src/index.ts

+    }
+  }
+
+  logger.info('Updated kotlinOptions to compilerOptions for Kotlin 2.2.0');


Suggested change

logger.info('Updated kotlinOptions to compilerOptions for Kotlin 2.2.0');

logger.info('Updated kotlinOptions to compilerOptions for Kotlin 2');

While it was removed in 2.2.0, it was deprecated in 2, so better just say 2

jcesarmobile

I was testing on the privacy screen plugin and the kotlin version is not being updated because it's like:

ext {
    kotlin_version = '1.9.24'
}

instead of ext.kotlin_version = '1.9.24'.
I did a code search in our org and find some others, so we should handle that too.

OS-pedrogustavobilro · 2025-12-02T09:35:29Z

I was testing on the privacy screen plugin and the kotlin version is not being updated

Hmm this was working before in this PR, so something must have broken it.

OS-ruimoreiramendes · 2025-12-02T09:57:26Z

I was testing on the privacy screen plugin and the kotlin version is not being updated

Hmm this was working before in this PR, so something must have broken it.

This might be related to the changes in this commit

OS-ruimoreiramendes · 2025-12-02T10:40:37Z

I was testing on the privacy screen plugin and the kotlin version is not being updated because it's like:
ext {
    kotlin_version = '1.9.24'
}
instead of ext.kotlin_version = '1.9.24'. I did a code search in our org and find some others, so we should handle that too.

The goal is to update the version in both cases, correct?

When

ext {
    kotlin_version = '1.9.24'
}

should be converted to

ext {
    kotlin_version = 'x.x.x'
}

When
ext.kotlin_version = '1.9.24'

should be converted to

ext.kotlin_version = 'x.x.x'

jcesarmobile · 2025-12-02T10:47:20Z

should be converted to kotlin_version = project.hasProperty("kotlin_version") ? rootProject.ext.kotlin_version : '2.2.20'

jcesarmobile

Just noticed it's not updating typescript, it should update to "typescript": "^5.9.3" as we did on ionic-team/capacitor-plugins@4c05924

OS-pedrogustavobilro · 2025-12-02T14:23:57Z

@jcesarmobile in that case should update @types/node as well, as we had to do for some plugins otherwise builds may fail? e.g. https://github.com/ionic-team/capacitor-geolocation/pull/63/files#diff-197d2f3d2108bd4f19137a72da4e4179f0333faa653397e4035bd4461d784969R64

src/index.ts

jcesarmobile · 2025-12-02T15:47:07Z

src/index.ts

  }
+  if (pluginJSON.devDependencies?.['typescript']) {
+    pluginJSON.devDependencies['typescript'] = typeScriptVersion;
+    if (pluginJSON.devDependencies?.['@types/node']) {


but don't check if @types/node is present, the build problem happens if typescript gets updated and adding @types/node is a workaround to make it work again, so we need to add it if it's not there

hm yeah, I see

jcesarmobile · 2025-12-03T09:33:16Z

Turns out that what was causing the build problems when updating the typescript version was @capacitor/docgen, I've released a 0.3.1 version that no longer requires to include @types/node.
Can you update the @capacitor/docgen dependency to 0.3.1 and remove the @types/node addition or put the code back to update it only if it was already present?

OS-ruimoreiramendes · 2025-12-03T11:04:15Z

Turns out that what was causing the build problems when updating the typescript version was @capacitor/docgen, I've released a 0.3.1 version that no longer requires to include @types/node. Can you update the @capacitor/docgen dependency to 0.3.1 and remove the @types/node addition or put the code back to update it only if it was already present?

@jcesarmobile pushed new changes with this

jcesarmobile · 2025-12-03T12:52:39Z

If a plugin has implementation "org.jetbrains.kotlin:kotlin-stdlib:1.9.25" it gets converted to implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" even if there is no kotlin_version declared, if there is no kotlin_version declared it should be turned into "org.jetbrains.kotlin:kotlin-stdlib:2.2.20"`

And also for classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.25", in this case it's not getting transformed, but isn't getting updated neither.

…ugin

OS-ruimoreiramendes · 2025-12-03T15:40:42Z

If a plugin has implementation "org.jetbrains.kotlin:kotlin-stdlib:1.9.25" it gets converted to implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" even if there is no kotlin_version declared, if there is no kotlin_version declared it should be turned into "org.jetbrains.kotlin:kotlin-stdlib:2.2.20"`

And also for classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.25", in this case it's not getting transformed, but isn't getting updated neither.

Pushed a new commit with these changes.
PS: Sorry, I closed the PR by mistake, it’s open again.

ItsChaceD added 4 commits November 6, 2025 10:12

feat: migrate from cap 7 to cap 8

248a4b7

add kotlin 2.2 migration

0a61107

fix propName deprecations and simplify kotlinOptions replacement

de0954e

change plugin version to 8.0.0

33fadb4

ItsChaceD requested a review from a team November 11, 2025 21:09

ItsChaceD marked this pull request as ready for review November 11, 2025 21:11

OS-ruimoreiramendes approved these changes Nov 12, 2025

View reviewed changes

OS-pedrogustavobilro reviewed Nov 12, 2025

View reviewed changes

update lib versions, package version, and replace compileSdkVersion

d83c2ea

ItsChaceD requested review from a team, OS-pedrogustavobilro and jcesarmobile November 12, 2025 18:18

ItsChaceD added 3 commits November 12, 2025 12:21

update core version to next

4334174

remove compileSdkVersion logic

ddb2804

update android lib versions

a5e9677

jcesarmobile reviewed Nov 12, 2025

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

revert core version to alpha

a4d9370

jcesarmobile reviewed Nov 12, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

add carat back in

ee5c903

ItsChaceD requested a review from jcesarmobile November 13, 2025 16:17

ItsChaceD added 2 commits November 13, 2025 12:47

optionally set kotlin version

402c007

change kotlin start

7895323

OS-pedrogustavobilro reviewed Nov 14, 2025

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

update npm dependencies

cddf24f

ItsChaceD requested a review from OS-pedrogustavobilro November 14, 2025 16:42

update to beta

c0ea9d0

OS-pedrogustavobilro requested changes Nov 17, 2025

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

fix kotlin version regex and update npm dependencies in migrate script

8505134

ItsChaceD requested a review from OS-pedrogustavobilro November 19, 2025 14:54

jcesarmobile reviewed Nov 19, 2025

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

OS-ruimoreiramendes requested a review from jcesarmobile November 28, 2025 15:30

jcesarmobile reviewed Dec 1, 2025

View reviewed changes

jcesarmobile requested changes Dec 1, 2025

View reviewed changes

update logger.info message in updateKotlinOptions

5ae21b7

jcesarmobile requested changes Dec 2, 2025

View reviewed changes

OS-ruimoreiramendes added 3 commits December 2, 2025 14:36

added new regex to update kotlin_version

187033b

added new regex to update kotlin_version

c973568

update typescript and types/node

8794872

OS-ruimoreiramendes requested a review from jcesarmobile December 2, 2025 15:02

jcesarmobile reviewed Dec 2, 2025

View reviewed changes

src/index.ts Show resolved Hide resolved

change typeScript and types/node update logic

2aa42c6

OS-ruimoreiramendes requested a review from jcesarmobile December 2, 2025 15:42

jcesarmobile reviewed Dec 2, 2025

View reviewed changes

remove types/node check

e60e5fb

OS-ruimoreiramendes requested a review from jcesarmobile December 2, 2025 16:11

update @capacitor/docgen version

1b6e88f

fix kotlin-stdlib transform and add new tranform for kotlin-gradle-pl…

fd9e010

…ugin

OS-ruimoreiramendes closed this Dec 3, 2025

OS-ruimoreiramendes reopened this Dec 3, 2025

jcesarmobile approved these changes Dec 5, 2025

View reviewed changes

	logger.info('Updated kotlinOptions to compilerOptions for Kotlin 2.2.0');
	logger.info('Updated kotlinOptions to compilerOptions for Kotlin 2');

feat: migrate from cap 7 to cap 8 #28

Are you sure you want to change the base?

feat: migrate from cap 7 to cap 8 #28

Uh oh!

Conversation

ItsChaceD commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OS-ruimoreiramendes commented Nov 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcesarmobile left a comment

Choose a reason for hiding this comment

Uh oh!

OS-pedrogustavobilro commented Dec 2, 2025

Uh oh!

OS-ruimoreiramendes commented Dec 2, 2025

Uh oh!

OS-ruimoreiramendes commented Dec 2, 2025

Uh oh!

jcesarmobile commented Dec 2, 2025

Uh oh!

jcesarmobile left a comment

Choose a reason for hiding this comment

Uh oh!

OS-pedrogustavobilro commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcesarmobile commented Dec 3, 2025

Uh oh!

OS-ruimoreiramendes commented Dec 3, 2025

Uh oh!

jcesarmobile commented Dec 3, 2025

Uh oh!

OS-ruimoreiramendes commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ItsChaceD commented Nov 10, 2025 •

edited

Loading

OS-pedrogustavobilro commented Dec 2, 2025 •

edited

Loading