Skip to content

Conversation

@0-th
Copy link
Contributor

@0-th 0-th commented Mar 17, 2025

No description provided.

@0-th 0-th changed the title chore(test): correctly name compatibility test case chore(test): fix wrongly named compatibility test case Mar 17, 2025
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, thanks; thankfully the Go version of this says the right thing, I'm not sure how this one got implemented wrong: https://github.com/ipld/go-codec-dagpb/blob/95c98e6afea77a5490455fb03f5a6c6a84993e20/compat_test.go#L190

@rvagg rvagg merged commit af3a132 into ipld:master Mar 17, 2025
19 checks passed
@0-th
Copy link
Contributor Author

0-th commented Mar 17, 2025

you're welcome.
I'm noticing all these as i'm trying to replicate the tests in this repo in the python implementation: https://github.com/storacha/py-ipld-dag-pb

github-actions bot pushed a commit that referenced this pull request May 8, 2025
## [4.1.4](v4.1.3...v4.1.4) (2025-05-08)

### Trivial Changes

* **test:** correctly name compatibility test case ([#102](#102)) ([af3a132](af3a132))
* **test:** fix wrongly named test case ([#101](#101)) ([345439f](345439f))

### Dependencies

* **dev:** bump aegir from 45.2.1 to 46.0.0 ([#104](#104)) ([7b80582](7b80582))
@github-actions
Copy link

github-actions bot commented May 8, 2025

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants