Skip to content

Commit 49a3521

Browse files
committed
ci: make internal job names more consistent w/ templates'
- Adding a matrix and `bahmutov/npm-install` brought the templates closer to internal, now do the inverse - Add "Checkout repo" name for checkout Action - previously had no name internally - Reorder config options for matrix to match templates - Use "Node" consistently, not "node" or "Node.js" - Also upgrade to actions/checkout@v2 since the templates have had that since their inception
1 parent 8449699 commit 49a3521

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ jobs:
1111
name: Lint & Deduplicate deps on node 10.x and ubuntu-latest
1212

1313
steps:
14-
- uses: actions/checkout@v1
15-
- name: Use Node.js 10.x
14+
- name: Checkout repo
15+
uses: actions/checkout@v2
16+
- name: Use Node 10.x
1617
uses: actions/setup-node@v1
1718
with:
1819
node-version: 10.x
@@ -27,18 +28,18 @@ jobs:
2728
run: yarn deduplicate:check
2829

2930
test:
30-
runs-on: ${{ matrix.os }}
31+
name: Test on Node ${{ matrix.node }} and ${{ matrix.os }}
3132

33+
runs-on: ${{ matrix.os }}
3234
strategy:
3335
matrix:
3436
node: ['10.x', '12.x', '14.x']
3537
os: [ubuntu-latest, windows-latest, macOS-latest]
3638

37-
name: Test on node ${{ matrix.node }} and ${{ matrix.os }}
38-
3939
steps:
40-
- uses: actions/checkout@v1
41-
- name: Use Node.js ${{ matrix.node }}
40+
- name: Checkout repo
41+
uses: actions/checkout@v2
42+
- name: Use Node ${{ matrix.node }}
4243
uses: actions/setup-node@v1
4344
with:
4445
node-version: ${{ matrix.node }}

0 commit comments

Comments
 (0)