Skip to content

Commit e36a7da

Browse files
danbevjasnell
authored andcommitted
src: make Nghttp2Stream a class
Currently there is a compiler warning which only showed up after applying the fix for nodejs#85: In file included from ../src/node-http2-core.cc:1: ../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a struct here but previously declared as a class [-Wmismatched-tags] struct Nghttp2Stream : public std::enable_shared_from_this<Nghttp2Stream> { ^ ../src/node-http2-core.h:19:1: note: did you mean struct here? class Nghttp2Stream; ^~~~~ struct In file included from ../src/node-http2-core.cc:1: This commit attempts to fix this warning. PR-URL: nodejs#86 Ref: nodejs#85 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 22edcaf commit e36a7da

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/node_http2_core.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,8 @@ class Nghttp2Session {
239239
friend class Nghttp2Stream;
240240
};
241241

242-
struct Nghttp2Stream : public std::enable_shared_from_this<Nghttp2Stream> {
242+
class Nghttp2Stream : public std::enable_shared_from_this<Nghttp2Stream> {
243+
public:
243244
inline ~Nghttp2Stream();
244245

245246
inline int Write(

0 commit comments

Comments
 (0)