Minor Fix for Longest Streak with No Commit History #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the streak length is zero
Owner
|
Nice! Thanks for the contribution @brandon1024. I'm going to merge this and then will follow up with the compiled versions and new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a very minor issue that can be seen when a user has no commit history. The start and end date for the streak are shown as
null - null. See the screenshot below.@jasonlong This is my first time contributing to your project, and I'm not sure if you want the source transpiled to js for Chrome, Firefox and Safari for every PR. I can do this if needed. Interested in hearing your feedback as well.