Class checking: "instanceof"#398
Merged
jonnathan-ls merged 3 commits intojavascript-tutorial:masterfrom Jul 16, 2023
Merged
Conversation
Remove the original English paragraph.
odsantos
requested changes
Mar 16, 2023
Contributor
odsantos
left a comment
odsantos
left a comment
There was a problem hiding this comment.
Hi @danilolmc ,
Here is a review.
"importance: 5" is not translated (the number here is only an example).
Please, do not forget to replace English hyperlinks with Portuguese ones when those are available and their explanation is good enough for being a replacement.
I appreciate it if you tell me if you disagree with any suggestion.
Thank you,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
Contributor
Author
|
/done |
odsantos
approved these changes
Mar 16, 2023
Contributor
odsantos
left a comment
odsantos
left a comment
There was a problem hiding this comment.
Hi @danilolmc ,
We'll need to wait for a review by another maintainer for merging this translation.
Thank you,
Best wishes.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.