Skip to content

Commit d6b4aff

Browse files
jdxclaude
andcommitted
fix(plugins): address review feedback
- Fix `plugins uninstall` example to use full `mise plugins uninstall` command - Remove `elixir` from multi-install example since it's a core plugin - Strip `vfox-` prefix in get_name_from_path() and get_name_from_url() so `./vfox-cmake` correctly infers plugin name as "cmake" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 474099f commit d6b4aff

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

src/cli/plugins/install.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ use crate::{backend::unalias_backend, config::Settings};
2929
pub struct PluginsInstall {
3030
/// The name of the plugin to install
3131
/// e.g.: cmake, poetry
32-
/// Can specify multiple plugins: `mise plugins install cmake poetry elixir`
32+
/// Can specify multiple plugins: `mise plugins install cmake poetry`
3333
#[clap(required_unless_present = "all", verbatim_doc_comment)]
3434
new_plugin: Option<String>,
3535

@@ -186,6 +186,7 @@ fn get_name_from_url(url: &str) -> Result<String> {
186186
let name = name.strip_prefix("asdf-").unwrap_or(&name);
187187
let name = name.strip_prefix("rtx-").unwrap_or(name);
188188
let name = name.strip_prefix("mise-").unwrap_or(name);
189+
let name = name.strip_prefix("vfox-").unwrap_or(name);
189190
Ok(unalias_backend(name).to_string())
190191
}
191192

src/cli/plugins/link.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ fn get_name_from_path(path: &Path) -> String {
6565
let name = name.strip_prefix("asdf-").unwrap_or(name);
6666
let name = name.strip_prefix("rtx-").unwrap_or(name);
6767
let name = name.strip_prefix("mise-").unwrap_or(name);
68+
let name = name.strip_prefix("vfox-").unwrap_or(name);
6869
unalias_backend(name).to_string()
6970
}
7071

src/cli/plugins/uninstall.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,6 @@ impl PluginsUninstall {
6363
static AFTER_LONG_HELP: &str = color_print::cstr!(
6464
r#"<bold><underline>Examples:</underline></bold>
6565
66-
$ <bold>mise uninstall cmake</bold>
66+
$ <bold>mise plugins uninstall cmake</bold>
6767
"#
6868
);

0 commit comments

Comments
 (0)