From 18b48d3146211115aae2c2980bf90a7d9ac3fc97 Mon Sep 17 00:00:00 2001 From: Dustin Van Tate Testa Date: Tue, 8 Jul 2025 11:02:49 -0500 Subject: [PATCH 1/2] fix comment typo+grammar --- src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/index.ts b/src/index.ts index de9eeac..5b5e9da 100644 --- a/src/index.ts +++ b/src/index.ts @@ -177,7 +177,7 @@ export interface SerializeOptions { maxAge?: number; /** * Specifies the `Date` object to be the value for the [`Expires` `Set-Cookie` attribute](https://tools.ietf.org/html/rfc6265#section-5.2.1). - * When no expiration is set clients consider this a "non-persistent cookie" and delete it the current session is over. + * When no expiration is set, clients consider this a "non-persistent cookie" and delete it when the current session is over. * * The [cookie storage model specification](https://tools.ietf.org/html/rfc6265#section-5.3) states that if both `expires` and * `maxAge` are set, then `maxAge` takes precedence, but it is possible not all clients by obey this, @@ -186,7 +186,7 @@ export interface SerializeOptions { expires?: Date; /** * Specifies the value for the [`Domain` `Set-Cookie` attribute](https://tools.ietf.org/html/rfc6265#section-5.2.3). - * When no domain is set clients consider the cookie to apply to the current domain only. + * When no domain is set, clients consider the cookie to apply to the current domain only. */ domain?: string; /** From ff893279cc50f3613c5096dd9a473ef427a2dc91 Mon Sep 17 00:00:00 2001 From: Dustin Van Tate Testa Date: Wed, 9 Jul 2025 05:20:33 -0500 Subject: [PATCH 2/2] fix typo+grammar --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 54e1cda..f32c443 100644 --- a/README.md +++ b/README.md @@ -79,7 +79,7 @@ so if both are set, they should point to the same date and time. ##### expires Specifies the `Date` object to be the value for the [`Expires` `Set-Cookie` attribute](https://tools.ietf.org/html/rfc6265#section-5.2.1). -When no expiration is set clients consider this a "non-persistent cookie" and delete it the current session is over. +When no expiration is set, clients consider this a "non-persistent cookie" and delete it when the current session is over. The [cookie storage model specification](https://tools.ietf.org/html/rfc6265#section-5.3) states that if both `expires` and `maxAge` are set, then `maxAge` takes precedence, but it is possible not all clients by obey this, @@ -88,7 +88,7 @@ so if both are set, they should point to the same date and time. ##### domain Specifies the value for the [`Domain` `Set-Cookie` attribute](https://tools.ietf.org/html/rfc6265#section-5.2.3). -When no domain is set clients consider the cookie to apply to the current domain only. +When no domain is set, clients consider the cookie to apply to the current domain only. ##### path