Renamed TnefReader's internal Seek() method to Skip() to more accurately reflect what it does

(it doesn't actually Seek because Seek implies it can go backwards)

Author: jstedfast

MimeKit/Tnef/TnefPropertyReader.cs

@@ -401,7 +401,7 @@ byte[] ReadByteArray ()
 				// remaining bytes are padding
 				int padding = 4 - (length % 4);
 
-				reader.Seek (reader.StreamOffset + padding);
+				reader.Skip (padding);
 			}
 
 			return bytes;
@@ -610,7 +610,7 @@ public bool ReadNextValue ()
 
 			int offset = RawValueStreamOffset + RawValueLength;
 
-			if (reader.StreamOffset < offset && !reader.Seek (offset))
+			if (reader.StreamOffset < offset && !reader.Skip (offset - reader.StreamOffset))
 				return false;
 
 			try {

MimeKit/Tnef/TnefReader.cs

@@ -480,7 +480,7 @@ internal int ReadInt32 ()
 
 			UpdateChecksum (input, inputIndex, 4);
 
-			var result = BinaryPrimitives.ReadInt32LittleEndian (input.AsSpan(inputIndex));
+			var result = BinaryPrimitives.ReadInt32LittleEndian (input.AsSpan (inputIndex));
 
 			inputIndex += 4;
 
@@ -537,15 +537,15 @@ internal double ReadDouble ()
 			return result;
 		}
 
-		internal bool Seek (int offset)
+		internal bool Skip (int count)
 		{
 			CheckDisposed ();
 
-			int left = offset - StreamOffset;
-
-			if (left <= 0)
+			if (count <= 0)
 				return true;
 
+			int left = count;
+
 			do {
 				int n = Math.Min (inputEnd - inputIndex, left);
 
@@ -570,7 +570,7 @@ bool SkipAttributeRawValue ()
 			int offset = AttributeRawValueStreamOffset + AttributeRawValueLength;
 			int expected, actual;
 
-			if (!Seek (offset))
+			if (!Skip (offset - StreamOffset))
 				return false;
 
 			// Note: ReadInt16() will update the checksum, so we need to capture it here

UnitTests/Tnef/TnefReaderTests.cs

@@ -465,7 +465,7 @@ public void TestReadSingle ()
 		}
 
 		[Test]
-		public void TestSeekTruncatedLoose ()
+		public void TestSkipTruncatedLoose ()
 		{
 			using (var stream = new MemoryStream ()) {
 				stream.Write (BitConverter.GetBytes (0x223e9f78), 0, 4);
@@ -482,14 +482,14 @@ public void TestSeekTruncatedLoose ()
 				stream.Position = 0;
 
 				using (var reader = new TnefReader (stream, 0, TnefComplianceMode.Loose)) {
-					Assert.That (reader.Seek (64), Is.False, "Seek");
+					Assert.That (reader.Skip (64), Is.False, "Skip");
 					Assert.That (reader.ComplianceStatus, Is.EqualTo (TnefComplianceStatus.StreamTruncated));
 				}
 			}
 		}
 
 		[Test]
-		public void TestSeekTruncatedStrict ()
+		public void TestSkipTruncatedStrict ()
 		{
 			using (var stream = new MemoryStream ()) {
 				stream.Write (BitConverter.GetBytes (0x223e9f78), 0, 4);
@@ -507,7 +507,7 @@ public void TestSeekTruncatedStrict ()
 
 				using (var reader = new TnefReader (stream, 0, TnefComplianceMode.Strict)) {
 					try {
-						reader.Seek (64);
+						reader.Skip (64);
 						Assert.Fail ("Seek should have thrown TnefException");
 					} catch (TnefException ex) {
 						Assert.That (ex.Error, Is.EqualTo (TnefComplianceStatus.StreamTruncated), "Error");